Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] crm: email and manual leads #9345

Closed
wants to merge 1 commit into from

Conversation

jero-odoo
Copy link
Contributor

@jero-odoo jero-odoo commented May 15, 2024

Adding a new doc to outline the process of generating CRM leads via email alias or manual creation. This is intended to replace the existing Generating leads/opps doc. (Which will be removed after both this doc and the new webform doc are published)

Docs task: https://www.odoo.com/mail/view?model=project.task&res_id=3931235&access_token=3a69927b-7d03-4f2f-a5b2-935fa74d1b05

@jero-odoo jero-odoo self-assigned this May 15, 2024
@robodoo
Copy link
Collaborator

robodoo commented May 15, 2024

@jero-odoo jero-odoo force-pushed the 17.0-crm-email-manual-leads-jero branch 5 times, most recently from 74bbc5f to e794c9d Compare May 21, 2024 15:33
@jero-odoo jero-odoo marked this pull request as ready for review May 21, 2024 15:33
@C3POdoo C3POdoo requested a review from a team May 21, 2024 15:35
@jero-odoo jero-odoo requested a review from brse-odoo May 21, 2024 15:46
@jero-odoo
Copy link
Contributor Author

Hey @brse-odoo this is ready for review. Thank you!

Copy link
Contributor

@brse-odoo brse-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo I've finished my review of this PR, great job! Approving with very few suggestions for you to accept/reject as you see fit. Let me know if you have any questions, thanks!

@jero-odoo jero-odoo force-pushed the 17.0-crm-email-manual-leads-jero branch from 974c8da to fef2b15 Compare May 22, 2024 16:02
@jero-odoo
Copy link
Contributor Author

Hey @ksc-odoo this is ready for final review. Thanks!

@jero-odoo jero-odoo requested a review from a team May 22, 2024 16:18
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, @jero-odoo -- just finished my Final Review. Awesome job! Approving now 👍 only a handful of minor suggestions that require your attention. Once you implement the necessary adjustments, feel free to tag this for Tech Review. Thanks! 🙏

@jero-odoo jero-odoo force-pushed the 17.0-crm-email-manual-leads-jero branch from 02e4f12 to a4cf527 Compare May 23, 2024 19:25
@jero-odoo
Copy link
Contributor Author

Thanks KC!
@samueljlieber this is ready for tech review. Thanks!

@jero-odoo jero-odoo requested a review from a team May 23, 2024 19:37
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo! Awesome work on this new CRM doc– I really like how the information in this doc is structured 👏

Please update the commit message (using git commit --amend) to follow the naming convention:

[ADD] crm: email and manual leads

I am approving with a suggestion, thanks for your hard work on this!
.....
@robodoo delegate=jero-odoo

@jero-odoo jero-odoo force-pushed the 17.0-crm-email-manual-leads-jero branch from a4cf527 to 6d4464c Compare May 24, 2024 17:19
@jero-odoo jero-odoo changed the title [ADD] Email and Manual Leads [ADD] crm: email and manual leads May 24, 2024
Co-authored-by: brse-odoo <brse@odoo.com>

Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>

Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
@jero-odoo jero-odoo force-pushed the 17.0-crm-email-manual-leads-jero branch from 40709c6 to bd7637b Compare May 24, 2024 18:06
@jero-odoo
Copy link
Contributor Author

@robodoo r+

@fw-bot
Copy link
Collaborator

fw-bot commented May 28, 2024

@jero-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants