Skip to content

Commit

Permalink
[FIX] ColorPicker: Fix style issue
Browse files Browse the repository at this point in the history
Wrong style introduced in e95c1f8 as the class `o-color-picker-toggler`
has been applied to several divs as discriminant selectors in the tests.
I did not test this properly at forward port.

closes #2500

Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
  • Loading branch information
rrahir committed May 22, 2023
1 parent e95c1f8 commit 1333832
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/components/color_picker/color_picker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ css/* scss */ `
grid-template-columns: repeat(${ITEMS_PER_LINE}, 1fr);
grid-gap: ${ITEM_HORIZONTAL_MARGIN * 2}px;
}
.o-color-picker-toggler {
.o-color-picker-toggler-button {
display: flex;
.o-color-picker-toggler-sign {
margin: auto auto;
Expand Down
2 changes: 1 addition & 1 deletion src/components/color_picker/color_picker.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<span>Custom</span>
</div>
<div class="colors-grid o-color-picker-toggler" t-on-click.stop="toggleColorPicker">
<div class="o-color-picker-line-item o-color-picker-toggler">
<div class="o-color-picker-line-item o-color-picker-toggler-button">
<div class="o-color-picker-toggler-sign">
<t t-call="o-spreadsheet-Icon.PLUS"/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion tests/components/__snapshots__/color_picker.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ exports[`Color Picker buttons Full component rendering 1`] = `
class="colors-grid o-color-picker-toggler"
>
<div
class="o-color-picker-line-item o-color-picker-toggler"
class="o-color-picker-line-item o-color-picker-toggler-button"
>
<div
class="o-color-picker-toggler-sign"
Expand Down

0 comments on commit 1333832

Please sign in to comment.