[FIX] viewport: warning message on resized viewport size

Fix warning not closing issue caused by changing the value of
DEFAULT_SHEETVIEW_SIZE to 0 from 1000 in a previous PR #2188. The problem
arose due to xRatio and yRatio becoming NaN and Infinity prior to mounting.

To resolve this issue, Added an if condition that returns the function if either
xRatio or yRatio is Infinity.

Task-3318806

closes #2504

X-original-commit: 254ac6c
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

src/components/spreadsheet/spreadsheet.ts

@@ -264,6 +264,12 @@ export class Spreadsheet extends Component<SpreadsheetProps, SpreadsheetChildEnv
     const { xRatio, yRatio } = this.env.model.getters.getFrozenSheetViewRatio(
       this.env.model.getters.getActiveSheetId()
     );
+
+    if (!isFinite(xRatio) || !isFinite(yRatio)) {
+      // before mounting, the ratios can be NaN or Infinity if the viewport size is 0
+      return;
+    }
+
     if (yRatio > MAXIMAL_FREEZABLE_RATIO || xRatio > MAXIMAL_FREEZABLE_RATIO) {
       if (this.isViewportTooSmall) {
         return;

tests/components/spreadsheet.test.ts

@@ -1,6 +1,7 @@
-import { Model } from "../../src";
+import { Model, setDefaultSheetViewSize } from "../../src";
 import { OPEN_CF_SIDEPANEL_ACTION } from "../../src/actions/menu_items_actions";
 import { Spreadsheet } from "../../src/components";
+import { getDefaultSheetViewSize } from "../../src/constants";
 import { functionRegistry } from "../../src/functions";
 import { toZone } from "../../src/helpers";
 import { SpreadsheetChildEnv } from "../../src/types";
@@ -256,6 +257,19 @@ test("Spreadsheet detects frozen panes that exceed the limit size at start", asy
   expect(notifyUser).toHaveBeenCalled();
 });
 
+test("Warns user when viewport is too small for frozen panes but stops warning after resizing/Unmounted", async () => {
+  const originalViewSize = getDefaultSheetViewSize();
+
+  // Setting the sheet viewport size to 0 to represent the "real life" scenario where the default size is 0
+  setDefaultSheetViewSize(0);
+  const notifyUser = jest.fn();
+  const model = new Model({ sheets: [{ panes: { xSplit: 0, ySplit: 20 } }] });
+  ({ parent, fixture } = await mountSpreadsheet({ model }, { notifyUser }));
+  expect(notifyUser).toHaveBeenCalledTimes(0);
+
+  setDefaultSheetViewSize(originalViewSize);
+});
+
 test("Warn user only once when the viewport is too small for its frozen panes", async () => {
   const notifyUser = jest.fn();
   ({ parent, model, fixture } = await mountSpreadsheet(undefined, { notifyUser }));

tests/setup/resize_observer.mock.ts

@@ -6,7 +6,7 @@ class MockResizeObserver {
   observe() {
     //@ts-ignore
     global.resizers.add(this);
-    this.cb();
+    Promise.resolve().then(() => this.cb());
   }
 
   unobserve() {