[FIX] SplitIntoColumnsPanel: Panel closes instantly

There was a mistake in the code adaptation when we introduced the
stores.

How to reproduce:
- Open a spreadsheet
- Open "Topbar menu > Split text to columns"
-> The sidepanel opens and closes instantly

closes #3937

Task: 3829192
X-original-commit: baaba22
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

src/components/side_panel/split_to_columns_panel/split_to_columns_panel.ts

@@ -47,7 +47,14 @@ export class SplitIntoColumnsPanel extends Component<Props, SpreadsheetChildEnv>
     const composerStore = useStore(ComposerStore);
     // The feature makes no sense if we are editing a cell, because then the selection isn't active
     // Stop the edition when the panel is mounted, and close the panel if the user start editing a cell
-    useEffect(this.props.onCloseSidePanel, () => [composerStore.editionMode]);
+    useEffect(
+      (editionMode) => {
+        if (editionMode !== "inactive") {
+          this.props.onCloseSidePanel();
+        }
+      },
+      () => [composerStore.editionMode]
+    );
 
     onMounted(() => {
       composerStore.stopEdition();

tests/split_to_column/split_to_columns_panel.test.ts

@@ -166,6 +166,7 @@ describe("split to columns sidePanel component", () => {
   });
 
   test("Panel is closed if the user starts to edit a cell", async () => {
+    expect(onCloseSidePanel).not.toHaveBeenCalled();
     const composerStore = parent.env.getStore(ComposerStore);
     composerStore.startEdition();
     await nextTick();