Skip to content

Commit

Permalink
[FIX] conditional_formatting: fix cf type checkboxes
Browse files Browse the repository at this point in the history
The checkboxes of the CF side panel weren't working properly if we clicked
right between the checkbox input and it's label. The state of the component
changed, but the checkbox wasn't checked.

This is because we used `t-attf-checked` to defined the state of the checkbox,
which returns a string instead of a boolean. Changed it to `t-att-checked`.

closes #2538

X-original-commit: 183d380
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Minne Adrien (adrm) <adrm@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
  • Loading branch information
hokolomopo committed Jun 1, 2023
1 parent b3848ec commit 98c8b59
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
t-on-click="() => this.changeRuleType('CellIsRule')">
<input
class="form-check-input o_radio_input"
t-attf-checked="{{state.currentCFType === 'CellIsRule'}}"
t-att-checked="state.currentCFType === 'CellIsRule'"
type="radio"
id="cellIsRule"
name="ruleType"
Expand All @@ -62,7 +62,7 @@
t-on-click="() => this.changeRuleType('ColorScaleRule')">
<input
class="form-check-input o_radio_input"
t-attf-checked="{{state.currentCFType === 'ColorScaleRule'}}"
t-att-checked="state.currentCFType === 'ColorScaleRule'"
type="radio"
id="colorScaleRule"
name="ruleType"
Expand All @@ -78,7 +78,7 @@
t-on-click="() => this.changeRuleType('IconSetRule')">
<input
class="form-check-input o_radio_input"
t-attf-checked="{{state.currentCFType === 'IconSetRule'}}"
t-att-checked="state.currentCFType === 'IconSetRule'"
type="radio"
id="iconSetRule"
name="ruleType"
Expand Down

0 comments on commit 98c8b59

Please sign in to comment.