Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][Spreadsheet] Multiple Focus issues #1169

Closed
wants to merge 3 commits into from
Closed

[FW][Spreadsheet] Multiple Focus issues #1169

wants to merge 3 commits into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Feb 28, 2022

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : 2744035

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #1131

@robodoo
Copy link
Collaborator

robodoo commented Feb 28, 2022

Pull request status dashboard.

@fw-bot
Copy link
Collaborator Author

fw-bot commented Feb 28, 2022

Ping @rrahir, @LucasLefevre cherrypicking of pull request #1131 failed.

stderr:

10:16:46.872771 git.c:344               trace: built-in: git cherry-pick 3e2a61066aa8d8d370fceebbd56f1ce24d53dc43
error: Cherry-picking is not possible because you have unmerged files.
hint: Fix them up in the work tree, and then use 'git add/rm <file>'
hint: as appropriate to mark resolution and make a commit.
fatal: cherry-pick failed
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@rrahir rrahir force-pushed the saas-15.1-15.0-fix-focus-rar-1Dpp-fw branch from a72c8cd to 4d67ecc Compare February 28, 2022 09:42
@rrahir
[FIX] sidePanel: focus grid on close
8f360d5 
When closing the sidepanel, the focus was not given back to the
spredsheet and just defaulted on `document.body` since the DOMElement of
the sidepanel was simply removed.

Task 2744035
@rrahir
[FIX] menu: focus grid on close
684f2e0 
When closing the contextmenu, the focus was not given back to the
spredsheet and just defaulted on `document.body` since the DOMElement of
the contextmenu was simply removed.

Task 2744035
@rrahir
[FIX] figure: changing selection mode should not affect a selected fi…
229a4f2 
…gure

To reproduce:
 Select a figure,
 Hit Ctrl  down and up
 The figure lost its outline

This occurs because the selectedFigureId is resetted inside the
Selection Plugin.

Task 2744035
@rrahir rrahir force-pushed the saas-15.1-15.0-fix-focus-rar-1Dpp-fw branch from 768595d to 229a4f2 Compare February 28, 2022 09:46
@rrahir
Copy link
Collaborator

rrahir commented Feb 28, 2022

@robodoo rebase-ff r+

robodoo pushed a commit that referenced this pull request Feb 28, 2022
@rrahir
[FIX] sidePanel: focus grid on close
dae9334 
When closing the sidepanel, the focus was not given back to the
spredsheet and just defaulted on `document.body` since the DOMElement of
the sidepanel was simply removed.

Task 2744035

Part-of: #1169
robodoo pushed a commit that referenced this pull request Feb 28, 2022
@rrahir
[FIX] menu: focus grid on close
f48a2c5 
When closing the contextmenu, the focus was not given back to the
spredsheet and just defaulted on `document.body` since the DOMElement of
the contextmenu was simply removed.

Task 2744035

Part-of: #1169
robodoo pushed a commit that referenced this pull request Feb 28, 2022
@rrahir
[FIX] figure: changing selection mode should not affect a selected fi…
773e24a 
…gure

To reproduce:
 Select a figure,
 Hit Ctrl  down and up
 The figure lost its outline

This occurs because the selectedFigureId is resetted inside the
Selection Plugin.

Task 2744035

closes #1169

Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo
Copy link
Collaborator

robodoo commented Feb 28, 2022

Merge method set to rebase and fast-forward

@fw-bot fw-bot mentioned this pull request Feb 28, 2022
Closed
14 tasks
@robodoo robodoo closed this Feb 28, 2022
@robodoo robodoo temporarily deployed to merge February 28, 2022 09:58 Inactive
@fw-bot fw-bot deleted the saas-15.1-15.0-fix-focus-rar-1Dpp-fw branch March 14, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conflict forwardport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fw-bot @robodoo @rrahir