Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][FIX] data_source_tests: restore real timers #1206

Closed
wants to merge 1 commit into from
Closed

[FW][FIX] data_source_tests: restore real timers #1206

wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 10, 2022

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : 2758853

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #1199

@pro-odoo
[FIX] data_source_tests: restore real timers
1f2350f 
As mentioned in https://jestjs.io/docs/timer-mocks#:~:text=it is a
global operation and will affect other tests within the same file, the
faketimer operation is global and should be restored for future tests
if they don't need it.

Task-id 2758853

X-original-commit: 778c4ad
@robodoo
Copy link
Collaborator

robodoo commented Mar 10, 2022

Pull request status dashboard.

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 10, 2022

This PR targets saas-15.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot fw-bot mentioned this pull request Mar 10, 2022
Closed
14 tasks
robodoo pushed a commit that referenced this pull request Mar 10, 2022
@pro-odoo
[FIX] data_source_tests: restore real timers
86be98e 
As mentioned in https://jestjs.io/docs/timer-mocks#:~:text=it is a
global operation and will affect other tests within the same file, the
faketimer operation is global and should be restored for future tests
if they don't need it.

Task-id 2758853

closes #1206

X-original-commit: 778c4ad
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@robodoo robodoo closed this Mar 10, 2022
@robodoo robodoo temporarily deployed to merge March 10, 2022 11:01 Inactive
@fw-bot fw-bot deleted the saas-15.1-15.0-fix-ds-tests-pro-lrfk-fw branch March 24, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
forwardport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fw-bot @robodoo @pro-odoo