Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] tokenizer: strict position at the end of reference string #1290

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Apr 13, 2022

In the composer, type "=A1A" => boom

Commit f70cb5f removed the $ at the end of the range regex, meaning
A1A matches the regex

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #1289

In the composer, type "=A1A" => boom

Commit f70cb5f removed the $ at the end of the range regex, meaning
A1A matches the regex

X-original-commit: 785737d
@robodoo
Copy link
Collaborator

robodoo commented Apr 13, 2022

@fw-bot
Copy link
Collaborator Author

fw-bot commented Apr 13, 2022

This PR targets saas-15.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

robodoo pushed a commit that referenced this pull request Apr 13, 2022
In the composer, type "=A1A" => boom

Commit f70cb5f removed the $ at the end of the range regex, meaning
A1A matches the regex

closes #1290

X-original-commit: 785737d
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@robodoo robodoo closed this Apr 13, 2022
@robodoo robodoo temporarily deployed to merge April 13, 2022 17:56 Inactive
@fw-bot fw-bot deleted the saas-15.3-saas-15.2-strict-end-ref-regex-lul-fJll-fw branch April 27, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants