[FW][FIX] edition: do not reset selection when range selecting on differe… #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt sheet When starting a ranger selection in the composer, we would systematically reset the selection anchor to the cell that we were editing in the first place. This behaviour is required when a user edits a formula and wants to select some ranges by moving the position with their keyboard. e.g. User wants to sum several range together - they start editing cell A1 select a first cell anywhere on the grid, input a comma to add another zone, hit ArrowDown, it should select A2. Unfortunately, when selecting a range on another sheet, this behaviour does not make sense anymore since there is no guarantee that the anchor coordinates of the edited cell existes on another sheet. e.g. Edit on A1000 sheet 1 with 1000 rows, then move to sheet 2 with 10 rows, When selecting several ranges for a formula, you cannot be 'moved' to A1000 since it doesn't exist. To solve this, we choose to prevent the reset of the anchor when the current sheet differs from the sheet of the edited cell. task 2859417 X-original-commit: cdd61a0
|
This PR targets saas-15.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
May 20, 2022
…nt sheet When starting a ranger selection in the composer, we would systematically reset the selection anchor to the cell that we were editing in the first place. This behaviour is required when a user edits a formula and wants to select some ranges by moving the position with their keyboard. e.g. User wants to sum several range together - they start editing cell A1 select a first cell anywhere on the grid, input a comma to add another zone, hit ArrowDown, it should select A2. Unfortunately, when selecting a range on another sheet, this behaviour does not make sense anymore since there is no guarantee that the anchor coordinates of the edited cell existes on another sheet. e.g. Edit on A1000 sheet 1 with 1000 rows, then move to sheet 2 with 10 rows, When selecting several ranges for a formula, you cannot be 'moved' to A1000 since it doesn't exist. To solve this, we choose to prevent the reset of the anchor when the current sheet differs from the sheet of the edited cell. task 2859417 closes #1370 X-original-commit: cdd61a0 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
fw-bot
deleted the
saas-15.1-15.0-fix-cell-reset-on-composition-rar-hWDZ-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nt sheet
When starting a ranger selection in the composer, we would
systematically reset the selection anchor to the cell that we were
editing in the first place. This behaviour is required when a user edits
a formula and wants to select some ranges by moving the position with
their keyboard.
e.g. User wants to sum several range together -
they start editing cell A1
select a first cell anywhere on the grid,
input a comma to add another zone,
hit ArrowDown,
it should select A2.
Unfortunately, when selecting a range on another sheet, this behaviour
does not make sense anymore since there is no guarantee that the anchor
coordinates of the edited cell existes on another sheet.
e.g. Edit on A1000 sheet 1 with 1000 rows, then move to sheet 2 with 10
rows, When selecting several ranges for a formula, you cannot be 'moved'
to A1000 since it doesn't exist.
To solve this, we choose to prevent the reset of the anchor when the
current sheet differs from the sheet of the edited cell.
task 2859417
Description:
description of this task, what is implemented and why it is implemented that way.
Odoo task ID : TASK_ID
review checklist
Forward-Port-Of: #1369