[FW][FIX] edition: do not reset selection when range selecting on differe…

[fw-bot]

…nt sheet

When starting a ranger selection in the composer, we would
systematically reset the selection anchor to the cell that we were
editing in the first place. This behaviour is required when a user edits
a formula and wants to select some ranges by moving the position with
their keyboard.

e.g. User wants to sum several range together -
they start editing cell A1
select a first cell anywhere on the grid,
input a comma to add another zone,
hit ArrowDown,
it should select A2.

Unfortunately, when selecting a range on another sheet, this behaviour
does not make sense anymore since there is no guarantee that the anchor
coordinates of the edited cell existes on another sheet.

e.g. Edit on A1000 sheet 1 with 1000 rows, then move to sheet 2 with 10
rows, When selecting several ranges for a formula, you cannot be 'moved'
to A1000 since it doesn't exist.

To solve this, we choose to prevent the reset of the anchor when the
current sheet differs from the sheet of the edited cell.

task 2859417

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : TASK_ID

review checklist

• feature is organized in plugin, or UI components
• support of duplicate sheet (deep copy)
• in model/core: ranges are Range object, and can be adapted (adaptRanges)
• in model/UI: ranges are strings (to show the user)
• undo-able commands (uses this.history.update)
• multiuser-able commands (has inverse commands and transformations where needed)
• new/updated/removed commands are documented
• exportable in excel
• translations (_lt("qmsdf %s", abc))
• unit tested
• clean commented code
• track breaking changes
• doc is rebuild (npm run doc)
• status is correct in Odoo

Forward-Port-Of: #1369

[robodoo]

Pull request status dashboard.

[fw-bot]

Ping @rrahir, @pro-odoo cherrypicking of pull request #1369 failed.

stderr:

11:08:42.105882 git.c:344               trace: built-in: git cherry-pick dd20f76bbbcb648cd368db96e1f926f0139cc14d
error: could not apply dd20f76b... [FIX] edition: do not reset selection when range selecting on different sheet
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

[rrahir]

@robodoo r+