Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] top_bar: bugged top_bar menu item hitbox #1506

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jul 18, 2022

Description:

This commit modifies few attributes on xml level to fix the issue of
misleading hitbox for three top bar (toolbar) menu items. Due to click being
programmed in span a marginal boundary of that button was inactive,
which is resolved by moving the click event to parent attribute.

Odoo task ID : 2901921

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #1496
Forward-Port-Of: #1493

@robodoo
Copy link
Collaborator

robodoo commented Jul 18, 2022

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jul 18, 2022

Ping @somu-odoo, @pro-odoo cherrypicking of pull request #1493 failed.

stderr:

07:47:09.672139 git.c:344               trace: built-in: git cherry-pick 848353ccfe550685d6e6ad79e9c818a6e233f7ac
error: could not apply 848353cc... [FIX] top_bar: bugged top_bar menu item hitbox
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

This commit modifies few attributes on xml level to fix the issue of
misleading hitbox for three topbar menu items. Due to click being
programmed in span a marginal boundary of that button was inactive,
which is resolved by moving the click event to parent attribute.

Task-2901921

X-original-commit: bf2cf77
@somu-odoo somu-odoo force-pushed the saas-15.4-15.0-fix-toolbar-hitbox-issue-somu-Dxx2-fw branch from 598d818 to ee8545a Compare July 18, 2022 06:12
@somu-odoo
Copy link
Contributor

@pro-odoo I've resolved the conflicts, please check

@pro-odoo
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Jul 18, 2022
This commit modifies few attributes on xml level to fix the issue of
misleading hitbox for three topbar menu items. Due to click being
programmed in span a marginal boundary of that button was inactive,
which is resolved by moving the click event to parent attribute.

Task-2901921

closes #1506

X-original-commit: bf2cf77
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@robodoo robodoo closed this Jul 18, 2022
@robodoo robodoo temporarily deployed to merge July 18, 2022 06:23 Inactive
@fw-bot fw-bot deleted the saas-15.4-15.0-fix-toolbar-hitbox-issue-somu-Dxx2-fw branch August 1, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants