Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] evaluation: re-evaluate errors in other sheets #1510

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jul 19, 2022

Cell in errors in other sheets are not re-evaluated.
The error is rethrown right away when they are referenced.
This is not correct since formulas result may have changed
because of an asynchronous computation.

The issue is similar to the issue fixed in 35b67d3, but
with other sheets.

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #1509

@robodoo
Copy link
Collaborator

robodoo commented Jul 19, 2022

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jul 19, 2022

Ping @LucasLefevre, @pro-odoo cherrypicking of pull request #1509 failed.

stderr:

12:00:55.735012 git.c:344               trace: built-in: git cherry-pick ba6e8ee21c925987c6eac7d59d3638c23446a4aa
error: could not apply ba6e8ee2... [FIX] evaluation: re-evaluate errors in other sheets
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

Cell in errors in other sheets are not re-evaluated.
The error is rethrown right away when they are referenced.
This is not correct since formulas result may have changed
because of an asynchronous computation.

The issue is similar to the issue fixed in 35b67d3, but
with other sheets.

X-original-commit: ba6e8ee
Let's say a cell was previously evaluated to a given value,
then the user switch to another sheet. If the formula result changes
in the meantime (because of an async computations), the formula is not
re-evaluated (because it's not the active sheet).
When going back to the sheet, the user will still see the previous value.

X-original-commit: 2a25d90
@LucasLefevre LucasLefevre force-pushed the saas-15.1-15.0-errors-in-other-sheets-lul-iTgm-fw branch from 6d5da31 to 701ea1f Compare July 19, 2022 11:02
@LucasLefevre
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Jul 19, 2022
Cell in errors in other sheets are not re-evaluated.
The error is rethrown right away when they are referenced.
This is not correct since formulas result may have changed
because of an asynchronous computation.

The issue is similar to the issue fixed in 35b67d3, but
with other sheets.

X-original-commit: ba6e8ee
Part-of: #1510
robodoo pushed a commit that referenced this pull request Jul 19, 2022
Let's say a cell was previously evaluated to a given value,
then the user switch to another sheet. If the formula result changes
in the meantime (because of an async computations), the formula is not
re-evaluated (because it's not the active sheet).
When going back to the sheet, the user will still see the previous value.

closes #1510

X-original-commit: 2a25d90
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Jul 19, 2022
@robodoo robodoo temporarily deployed to merge July 19, 2022 11:12 Inactive
@fw-bot fw-bot deleted the saas-15.1-15.0-errors-in-other-sheets-lul-iTgm-fw branch August 2, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants