[FW][IMP] husky: allow use of pre-commit hook for windows #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PATH variable for husky in windows was sometimes missing the "/usr/bin" directory. I'm not sure what caused this, I had the bug sometimes but couldn't reproduce it consistently. On Windows, use `npx.cmd` instead of `npx`. Add a HUSKY_INPUT_ENV environment variable to disable user input in the pre-commit hook. It should be set to 0 if you use git with a GUI, in which you cannot use console input for commits X-original-commit: 6209577
|
This PR targets saas-15.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
Ping @hokolomopo, @rrahir
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Jul 19, 2022
The PATH variable for husky in windows was sometimes missing the "/usr/bin" directory. I'm not sure what caused this, I had the bug sometimes but couldn't reproduce it consistently. On Windows, use `npx.cmd` instead of `npx`. Add a HUSKY_INPUT_ENV environment variable to disable user input in the pre-commit hook. It should be set to 0 if you use git with a GUI, in which you cannot use console input for commits closes #1519 X-original-commit: 6209577 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PATH variable for husky in windows was missing the "/usr/bin" directory.
Add a HUSKY_INPUT_ENV environment variable to disable user input in
the pre-commit hook. It should be set to 0 if:
commands
Description:
description of this task, what is implemented and why it is implemented that way.
Odoo task ID : TASK_ID
review checklist
Forward-Port-Of: #1442