[FW][FIX] function: logical function "AND" traceback #1567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logical function `AND` caused a traceback when owl was in debug mode. This is because the two arguments of `AND` where both called `logical_expression1`. But since their name was used as a `t-key` of a `t-foreach`, it made owl crash because of the duplicated key. Odoo task 2937632 X-original-commit: ba132db
|
This PR targets saas-15.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Aug 5, 2022
The logical function `AND` caused a traceback when owl was in debug mode. This is because the two arguments of `AND` where both called `logical_expression1`. But since their name was used as a `t-key` of a `t-foreach`, it made owl crash because of the duplicated key. Odoo task 2937632 closes #1567 X-original-commit: ba132db Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Minne Adrien (adrm) <adrm@odoo.com>
fw-bot
deleted the
saas-15.1-master-and-function-traceback-owl-adrm-gZvV-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logical function
ANDcaused a traceback when owl was in debug mode.This is because the two arguments of
ANDwhere both calledlogical_expression1. But since their name was used as at-keyof at-foreach, it made owl crash because of the duplicated key.Odoo task ID : 2937632
review checklist
Forward-Port-Of: #1565
Forward-Port-Of: #1559