[FW][FIX] collaborative: do not transform commands in other dimension #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transformations of `gridDependentCommand's should skip the transformation when the executed and transformed commands are applied to different dimensions. e.g. `DELETE_COLUMNS_ROWS` in dimension `COL` should not alter `HIDE_COLUMSN_ROWS` in dimension `ROW`. task 2996249 X-original-commit: 10e9873
|
This PR targets saas-15.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Sep 26, 2022
Transformations of `gridDependentCommand's should skip the transformation when the executed and transformed commands are applied to different dimensions. e.g. `DELETE_COLUMNS_ROWS` in dimension `COL` should not alter `HIDE_COLUMSN_ROWS` in dimension `ROW`. task 2996249 closes #1665 X-original-commit: 10e9873 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transformations of `gridDependentCommand's should skip the transformation when the executed and transformed commands are applied to different dimensions.
e.g.
DELETE_COLUMNS_ROWSin dimensionCOLshould not alterHIDE_COLUMSN_ROWSin dimensionROW.task 2996249
Description:
description of this task, what is implemented and why it is implemented that way.
Odoo task ID : TASK_ID
review checklist
Forward-Port-Of: #1663