[FIX] functions: properly handle dates #1811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In several formulas, the comparison/lookup processes were not handling non primitive types correctly (such as `InternalDate`objects). This iossue was solved in a broad refactoring which is unfortunately quite hard to backport. This commit tries to address the issue by extracting the primitive number value of dates before feeding it to the comparison/search processes. Related opw 2992901 task 3002026
|
@fw-bot ignore |
|
Forward-port disabled. |
|
robodoo delegate=laa-odoo |
|
What about the MINUS formula ? Do we want to support these changes for this formula too ? |
my bad, not appropriate here |
laa-odoo
approved these changes
Nov 16, 2022
|
robodoo r+ |
|
rebase-ff |
|
robodoo rebase-ff |
robodoo
pushed a commit
that referenced
this pull request
Nov 16, 2022
robodoo
pushed a commit
that referenced
this pull request
Nov 16, 2022
In several formulas, the comparison/lookup processes were not handling non primitive types correctly (such as `InternalDate`objects). This iossue was solved in a broad refactoring which is unfortunately quite hard to backport. This commit tries to address the issue by extracting the primitive number value of dates before feeding it to the comparison/search processes. Related opw 2992901 task 3002026 closes #1811 Signed-off-by: laa-odoo <laa@odoo.com>
|
Merge method set to rebase and fast-forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Odoo task ID : 3002026
review checklist