Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/ publish package #2059

Closed
wants to merge 3 commits into from
Closed

Release/ publish package #2059

wants to merge 3 commits into from

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Feb 8, 2023

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Feb 8, 2023

src/components/spreadsheet.ts Outdated Show resolved Hide resolved
- Adapt code to the global typing of `owl`: owl 1.x typing did not
resolve properly with our imports.
- Split build commands to generate demo build and release builds
- Add generation of type files.

Task 3086110
@rrahir rrahir force-pushed the 15.0-release-rar branch 2 times, most recently from 395fd50 to aeff40a Compare February 9, 2023 12:19
@rrahir rrahir marked this pull request as ready for review February 9, 2023 12:39
@rrahir
Copy link
Collaborator Author

rrahir commented Feb 9, 2023

@fw-bot ignore

@fw-bot
Copy link
Collaborator

fw-bot commented Feb 9, 2023

Forward-port disabled.

@rrahir
Copy link
Collaborator Author

rrahir commented Feb 9, 2023

@robodoo rebase-ff

@robodoo
Copy link
Collaborator

robodoo commented Feb 9, 2023

I'm sorry, @rrahir: you can't method=rebase-ff.

[IMP] First release
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

@LucasLefevre
Copy link
Collaborator

robodoo rebase-ff

@robodoo
Copy link
Collaborator

robodoo commented Feb 27, 2023

Merge method set to rebase and fast-forward.

robodoo pushed a commit that referenced this pull request Feb 27, 2023
- Adapt code to the global typing of `owl`: owl 1.x typing did not
resolve properly with our imports.
- Split build commands to generate demo build and release builds
- Add generation of type files.

Task 3086110

Part-of: #2059
robodoo pushed a commit that referenced this pull request Feb 27, 2023
robodoo pushed a commit that referenced this pull request Feb 27, 2023
[IMP] First release

closes #2059

Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo temporarily deployed to merge February 27, 2023 14:03 Inactive
@robodoo robodoo closed this Feb 27, 2023
@fw-bot fw-bot deleted the 15.0-release-rar branch March 13, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants