[FIX] model: prevent UI plugins to refuse core commands

[hokolomopo]

Description

Currently it's possible for UI plugins to handle and refuse core commands in the allowDispatch. This is a problem because this could lead to de-synchronized states in multi-user.

This commit fixes this by making sure that the core commands don't go through the allowDispatch of the UI plugins.

Odoo task ID : 3209463

review checklist

• feature is organized in plugin, or UI components
• support of duplicate sheet (deep copy)
• in model/core: ranges are Range object, and can be adapted (adaptRanges)
• in model/UI: ranges are strings (to show the user)
• undo-able commands (uses this.history.update)
• multiuser-able commands (has inverse commands and transformations where needed)
• new/updated/removed commands are documented
• exportable in excel
• translations (_lt("qmsdf %s", abc))
• unit tested
• clean commented code
• track breaking changes
• doc is rebuild (npm run doc)
• status is correct in Odoo

[robodoo]

Pull request status dashboard.

[hokolomopo]

Note : I changed the allowDispatch interface of the current local plugins, but I couldn't find a way to type UI plugins correctly to prevent them from handling core commands. Someone could create a UI plugin w/ allowDispatch(cmd : LocalCommand | CoreCommand) and ts wouldn't complain.

We can do shit like that in ts, w/o typing error:

[hokolomopo]

@LucasLefevre any ideas?

[LucasLefevre]

You can't prevent that.

Nothing prevents a subclass to have a more general API than its parent, as long as it implements the parent's interface.

class A {
  coucou(a: number) {
    return true
  }
}
class B extends A {
  coucou(n: number | string) {
    return true
  }
}

Let's say I have a: A; but a is actually an instance of B under the hood, but I don't know it. It's totally fine, I don't care that a can actually handle/do more stuff, I just use it as an A and will give it only numbers

However, if it doesn't have the same API than the parent, then it does work.

class B2 extends A {
  // error: Type 'number' is not assignable to type 'string'
  coucou(n: string) {
    return true
  }
}

Here since LocalCommand (parent API) is assignable to LocalCommand | CoreCommand (child class), everything is fine.

cc @anhe-odoo

[LucasLefevre]

robodoo r+ 👍