Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] config: Fix the action version extractor #2124

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 1, 2023

the tool 'parse_message' was using an incorrect regex to capture the version of the release. It specifically pose problem with the master release for which the alpha tag was not considered, implying that 2 consecutive master release would have the same tag, which crashes and ultimately prevent further steps of the github action, like the publication on NPM.

We can rather rely on the information of the package.json file since it's properly updated.

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #2123

@robodoo
Copy link
Collaborator

robodoo commented Mar 1, 2023

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 1, 2023

@rrahir @LucasLefevre cherrypicking of pull request #2123 failed.

stdout:

Auto-merging tools/parse_message.js
CONFLICT (content): Merge conflict in tools/parse_message.js

stderr:

08:51:09.018654 git.c:455               trace: built-in: git cherry-pick b39921e1dae3ee96bdbb9edc58e51b00d6f3feeb
error: could not apply b39921e1... [FIX] config: Fix the action version extractor
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

the tool 'parse_message' was using an incorrect regex to capture the
version of the release. It specifically pose problem with the master
release for which the `alpha` tag was not considered, implying that 2
consecutive master release would have the same tag, which crashes and
ultimately prevent further steps of the github action, like the
publication on NPM.

We can rather rely on the information of the package.json file since
it's properly updated.

X-original-commit: d2361e2
@rrahir rrahir force-pushed the 15.0-14.0-fix-package-release-rar-5JWA-fw branch from 6308b9c to 146416e Compare March 1, 2023 09:51
@rrahir
Copy link
Collaborator

rrahir commented Mar 1, 2023

@robodoo r+

robodoo pushed a commit that referenced this pull request Mar 1, 2023
the tool 'parse_message' was using an incorrect regex to capture the
version of the release. It specifically pose problem with the master
release for which the `alpha` tag was not considered, implying that 2
consecutive master release would have the same tag, which crashes and
ultimately prevent further steps of the github action, like the
publication on NPM.

We can rather rely on the information of the package.json file since
it's properly updated.

closes #2124

X-original-commit: d2361e2
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo temporarily deployed to merge March 1, 2023 10:03 Inactive
@robodoo robodoo closed this Mar 1, 2023
@fw-bot fw-bot deleted the 15.0-14.0-fix-package-release-rar-5JWA-fw branch March 15, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants