[IMP] config: improve the versionning of gh releases and npm publications #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently do not specify any tag when publishing on NPM, which defaults to `latest`. Since we don't want old versions to be tagged as such, we add a tag in `package.json` to control which version has the flag `latest`. Note that according to the NPM documentation[1], the tag cannot match a semVer range [2][3] which is why we use a special tag that only indentifies the major version of the package. [1] https://docs.npmjs.com/cli/v9/commands/npm-dist-tag#caveats [2] https://semver.org/ [3] https://www.telerik.com/blogs/the-mystical-magical-semver-ranges-used-by-npm-bower
When creating a GH release, the default option is to set it as the latest one. By disabling this option, we rely on the semantic version of the release tag to define the latest release. We can also set the prerelease option to flag potentially unstable releases. References: [1] https://github.blog/changelog/2022-10-21-explicitly-set-the-latest-release/ [2] https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28 [3] https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository
|
@fw-bot ignore |
|
Forward-port disabled. |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Mar 1, 2023
We currently do not specify any tag when publishing on NPM, which defaults to `latest`. Since we don't want old versions to be tagged as such, we add a tag in `package.json` to control which version has the flag `latest`. Note that according to the NPM documentation[1], the tag cannot match a semVer range [2][3] which is why we use a special tag that only indentifies the major version of the package. [1] https://docs.npmjs.com/cli/v9/commands/npm-dist-tag#caveats [2] https://semver.org/ [3] https://www.telerik.com/blogs/the-mystical-magical-semver-ranges-used-by-npm-bower Part-of: #2136
robodoo
pushed a commit
that referenced
this pull request
Mar 1, 2023
When creating a GH release, the default option is to set it as the latest one. By disabling this option, we rely on the semantic version of the release tag to define the latest release. We can also set the prerelease option to flag potentially unstable releases. References: [1] https://github.blog/changelog/2022-10-21-explicitly-set-the-latest-release/ [2] https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28 [3] https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository closes #2136 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Odoo task ID : TASK_ID
review checklist