Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REV] changes in chart plugin structure #2150

Closed
wants to merge 2 commits into from
Closed

[REV] changes in chart plugin structure #2150

wants to merge 2 commits into from

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Mar 2, 2023

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : 3213661

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@rrahir
[REV] figure,chart: Prevent destructive creation
e52986c 
Since we did not verify the coherence of the commands payload in the
past, we cannot trust them and cannot rely on it now.

This reverts commit 8746ac1.
@rrahir
[REV] charts: Fix chart duplicated ids
4150cfb 
This change is not compatible with some commands in odoo ,which do not
contain the sheet id.

This reverts commit dbf469f.
@robodoo
Copy link
Collaborator

robodoo commented Mar 2, 2023

Pull request status dashboard.

@rrahir rrahir changed the title Revert fix for chart plugin structure [REV] changes in chart plugin structure Mar 2, 2023
LucasLefevre
LucasLefevre reviewed Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

@LucasLefevre
Copy link
Collaborator

robodoo rebase-ff

@robodoo
Copy link
Collaborator

robodoo commented Mar 2, 2023

Merge method set to rebase and fast-forward.

robodoo pushed a commit that referenced this pull request Mar 2, 2023
@rrahir
[REV] figure,chart: Prevent destructive creation
313e965 
Since we did not verify the coherence of the commands payload in the
past, we cannot trust them and cannot rely on it now.

This reverts commit 8746ac1.

Part-of: #2150
robodoo pushed a commit that referenced this pull request Mar 2, 2023
@rrahir
[REV] charts: Fix chart duplicated ids
fe7b9ff 
This change is not compatible with some commands in odoo ,which do not
contain the sheet id.

This reverts commit dbf469f.

closes #2150

Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo temporarily deployed to merge March 2, 2023 12:31 Inactive
@fw-bot fw-bot mentioned this pull request Mar 2, 2023
Closed
14 tasks
@robodoo robodoo closed this Mar 2, 2023
This was referenced Mar 2, 2023
Closed
Closed
Closed
@fw-bot fw-bot deleted the 15.0-shame-revert-rar branch March 16, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasLefevre LucasLefevre LucasLefevre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rrahir @robodoo @LucasLefevre