[FW] 14 better scripts lul #2197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LucasLefevre @rrahir cherrypicking of pull request #2191 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
Add the task label before every log line in the console. This helps to know what is logging what. The current task \"build:* -- --watch\" is split into smaller task without argument. Otherwise, the labels would also include the argument, making it very long [build:js -- --watch] => [watch:ts] the "serve" task is also rename to better reflect what it does: serving static files. In v15, we also have a "server" task which could be confusing
Currently, every file is watched by the static server. including typescript files and intermediary js files. But the static server only cares about the bundle file and demo files.
In v15, a collaborative server was introduced. This server can raise errors (let's say if it cannot start because the port is already used). In the current situation, errors are cleared by ts watch mode. This makes it difficult to see and know what happened.
Exit events that are fired following an error of exectuion were silently caught. This would hide the reason of failure and make it very difficult to know what happened.
rrahir
force-pushed
the
15.0-14-better-scripts-lul-pIxZ-fw
branch
from
5e73310
to
398c72b
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 9, 2023
Add the task label before every log line in the console. This helps to know what is logging what. The current task \"build:* -- --watch\" is split into smaller task without argument. Otherwise, the labels would also include the argument, making it very long [build:js -- --watch] => [watch:ts] the "serve" task is also rename to better reflect what it does: serving static files. In v15, we also have a "server" task which could be confusing Part-of: #2197
robodoo
pushed a commit
that referenced
this pull request
Mar 9, 2023
Currently, every file is watched by the static server. including typescript files and intermediary js files. But the static server only cares about the bundle file and demo files. Part-of: #2197
robodoo
pushed a commit
that referenced
this pull request
Mar 9, 2023
In v15, a collaborative server was introduced. This server can raise errors (let's say if it cannot start because the port is already used). In the current situation, errors are cleared by ts watch mode. This makes it difficult to see and know what happened. Part-of: #2197
robodoo
pushed a commit
that referenced
this pull request
Mar 9, 2023
Exit events that are fired following an error of exectuion were silently caught. This would hide the reason of failure and make it very difficult to know what happened. closes #2197 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Odoo task ID : TASK_ID
review checklist
Forward-Port-Of: #2191