[FIX] demo: optional askConfirmation cancel argument #2243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument `cancel` of the method `askConfirmation` is optional, but the function `cancel` is always called in the demo, without checking if its defined. this lead to tracebacks if `cancel` is not defined.
hokolomopo
force-pushed
the
15.0-ask-confirmatipn-optional-cancel-adrm
branch
from
cdbe7eb
to
6f7589c
Compare
robodoo
pushed a commit
that referenced
this pull request
Mar 20, 2023
The argument `cancel` of the method `askConfirmation` is optional, but the function `cancel` is always called in the demo, without checking if its defined. this lead to tracebacks if `cancel` is not defined. closes #2243 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
14 tasks
|
@hokolomopo @pro-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
3 similar comments
|
@hokolomopo @pro-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@hokolomopo @pro-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@hokolomopo @pro-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
This was referenced Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument
cancelof the methodaskConfirmationis optional, but the functioncancelis always called in the demo, without checking if its defined. this lead to tracebacks ifcancelis not defined.Description:
description of this task, what is implemented and why it is implemented that way.
Odoo task ID : TASK_ID
review checklist