-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] clipboard: don't open composer on firefox #2257
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
@LucasLefevre @rrahir cherrypicking of pull request #2251 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
b3bf79e
to
389d8b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robodoo r+
14 tasks
Steps to reproduce: - open a spreadsheet with firefox - copy a cell - paste it somewhere else => the composer is open with the pasted content. Additional small fix in the content editable helper, the selection `start` was not clipped if it was greater than the content length. Note: it doesn't happen on Chrome because `ev.data` is null when pasting content. It doesn't correctly implements the spec https://w3c.github.io/input-events/#dfn-data opw-3236303 X-original-commit: c7f1486
389d8b3
to
55b7b86
Compare
robodoo r+ |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Ok... that's weird, but not a big deal.
But it gets better:
The composer opens in the same way, but it doesn't support multiline text!
This commit fixes the composer opening and it also makes the edition plugin more robust by removing any carriage return that could slip through.
Additional small fix in the content editable helper, the selection
start
was not clipped if it was greater than the content length.Note: it doesn't happen on Chrome because
ev.data
is null when pasting content. It doesn't correctly implements the spechttps://w3c.github.io/input-events/#dfn-data
opw-3236303
opw : 3236303
review checklist
Forward-Port-Of: #2254
Forward-Port-Of: #2251