[IMP] components: use a hook to register/clean up event listeners #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrahir
force-pushed
the
master-ref-listener-rar
branch
from
3cbb25f
to
b8e8a32
Compare
Comment on lines
11
to
12
| */ | ||
|
|
||
| export function useRefListener( |
There was a problem hiding this comment.
remove the additional line between the docstring and the function
| ...listener: Parameters<typeof addEventListener> | ||
| ) { | ||
| useEffect( | ||
| (el) => { |
There was a problem hiding this comment.
Suggested change
| (el) => { | |
| (el: HTMLElement | null) => { |
Currently, we register event listener on `Ref.el` upong mount and unmount steps of the component lifecycle. However, depending on the component structure, the element of the `Ref` could change from a rendering to another*, preventing the proper cleaing of the listener. This commit introduces a new hook to handle such cases more correctly. * an example can be found in component `SelectionInput`.
rrahir
force-pushed
the
master-ref-listener-rar
branch
from
b8e8a32
to
6e35167
Compare
robodoo
pushed a commit
that referenced
this pull request
May 19, 2023
Currently, we register event listener on `Ref.el` upong mount and unmount steps of the component lifecycle. However, depending on the component structure, the element of the `Ref` could change from a rendering to another*, preventing the proper cleaing of the listener. This commit introduces a new hook to handle such cases more correctly. * an example can be found in component `SelectionInput`. closes #2469 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we register event listener on
Ref.elupong mount and unmount steps of the component lifecycle.However, depending on the component structure, the element of the
Refcould change from a rendering to another*, preventing the proper cleaing of the listener.This commit introduces a new hook to handle such cases more correctly.
SelectionInput.Description:
description of this task, what is implemented and why it is implemented that way.
Odoo task ID : TASK_ID
review checklist