Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] ColorPicker: modified add custom color icon #2496

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented May 19, 2023

Description:

Fixed the positioning of the add custom color icon, replacing the hardcoded version with an SVG icon for improved visual appeal.

Odoo task ID : 3258627

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #2493
Forward-Port-Of: #2324

Fixed the positioning of the add custom color icon, replacing the hardcoded
version with an SVG icon for improved visual appeal.

Task: 3258627
X-original-commit: e95c1f8
@robodoo
Copy link
Collaborator

robodoo commented May 19, 2023

@fw-bot
Copy link
Collaborator Author

fw-bot commented May 19, 2023

@aath-odoo @rrahir this PR targets master and is the last of the forward-port chain.

To merge the full chain, say

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@rrahir
Copy link
Collaborator

rrahir commented May 19, 2023

@fw-bot r+

robodoo pushed a commit that referenced this pull request May 19, 2023
Fixed the positioning of the add custom color icon, replacing the hardcoded
version with an SVG icon for improved visual appeal.

closes #2496

Task: 3258627
X-original-commit: e95c1f8
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo temporarily deployed to merge May 19, 2023 10:18 Inactive
@robodoo robodoo closed this May 19, 2023
@robodoo robodoo added the 16.4 label May 19, 2023
@fw-bot fw-bot deleted the master-16.0-fix-color-picker-add-icon-aath-Km-q-fw branch June 2, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants