Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] Filters: fix filter id on sheet duplication #2635

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jun 26, 2023

The internal state of the filter plugin requires that the id in the table mapping matches the id of the related FilterTable object.

Task: 3384840

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : 3384840

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #2631

The internal state of the filter plugin requires that the id in the
table mapping matches the id of the related FilterTable object.

Task: 3384840
X-original-commit: 4a28f6e
@robodoo
Copy link
Collaborator

robodoo commented Jun 26, 2023

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jun 26, 2023

@LucasLefevre
Copy link
Collaborator

fw-bot r+

robodoo pushed a commit that referenced this pull request Jun 26, 2023
The internal state of the filter plugin requires that the id in the
table mapping matches the id of the related FilterTable object.

closes #2635

Task: 3384840
X-original-commit: 4a28f6e
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo temporarily deployed to merge June 26, 2023 12:20 Inactive
@robodoo robodoo closed this Jun 26, 2023
@robodoo robodoo added the 16.4 label Jun 26, 2023
@fw-bot fw-bot deleted the master-16.0-fix-filter-table-duplication-rar-pLV9-fw branch July 10, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants