Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][IMP] pr_template: match template with commit format #2668

Closed
wants to merge 1 commit into from
Closed

[FW][IMP] pr_template: match template with commit format #2668

wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jul 6, 2023

With the introduction of npm releases we decided to put the relation to the odoo task with the format "Task: xxxxx". This changes the PR template to match this format.

Odoo task ID : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #2661

@hokolomopo
[IMP] pr_template: match template with commit format
c7a2e32 
With the introduction of npm releases we decided to put the relation to
the odoo task with the format "Task: xxxxx". This changes the PR template
to match this format.

X-original-commit: c9e6ec9
@robodoo
Copy link
Collaborator

robodoo commented Jul 6, 2023

Pull request status dashboard.

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jul 6, 2023

@hokolomopo @LucasLefevre this PR targets master and is the last of the forward-port chain containing:

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@LucasLefevre
Copy link
Collaborator

fw-bot r+

robodoo pushed a commit that referenced this pull request Jul 6, 2023
@hokolomopo
[IMP] pr_template: match template with commit format
bd7271e 
With the introduction of npm releases we decided to put the relation to
the odoo task with the format "Task: xxxxx". This changes the PR template
to match this format.

closes #2668

X-original-commit: c9e6ec9
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo temporarily deployed to merge July 6, 2023 10:30 Inactive
@robodoo robodoo closed this Jul 6, 2023
@robodoo robodoo added the 16.4 label Jul 6, 2023
@fw-bot fw-bot deleted the master-master-pr-template-update-adrm-mq9W-fw branch July 20, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
16.4 forwardport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fw-bot @robodoo @LucasLefevre @hokolomopo