Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] edition: add extra rows for spreading formulas #3005

Closed
wants to merge 1 commit into from
Closed

[IMP] edition: add extra rows for spreading formulas #3005

wants to merge 1 commit into from

Conversation

hokolomopo
Copy link
Contributor

Description

The goal of this commit is to add extra rows to the spreadsheet when the user create a new spreading formula, but there is not enough rows for the formula to spread.

Task: : 3458203

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Oct 13, 2023

Pull request status dashboard.

@hokolomopo hokolomopo force-pushed the master-insert-row-for-spreading-formula-adrm branch from e8b2930 to dc3515b Compare October 13, 2023 08:07
@hokolomopo hokolomopo force-pushed the master-insert-row-for-spreading-formula-adrm branch 2 times, most recently from 7d65fe1 to 78b1c60 Compare December 11, 2023 07:29
@hokolomopo hokolomopo force-pushed the master-insert-row-for-spreading-formula-adrm branch from 78b1c60 to cea010e Compare December 13, 2023 12:46
@hokolomopo hokolomopo force-pushed the master-insert-row-for-spreading-formula-adrm branch from cea010e to 9922a56 Compare February 19, 2024 07:43
@hokolomopo hokolomopo force-pushed the master-insert-row-for-spreading-formula-adrm branch from 9922a56 to edf12ae Compare February 29, 2024 09:21
@hokolomopo
[IMP] edition: add extra rows for spreading formulas
5f13130 
The goal of this commit is to add extra rows to the spreadsheet when
the user create a new spreading formula, but there is not enough rows
for the formula to spread.

Task: 3458203
@hokolomopo hokolomopo force-pushed the master-insert-row-for-spreading-formula-adrm branch from edf12ae to 5f13130 Compare February 29, 2024 09:22
LucasLefevre
LucasLefevre approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 29, 2024
@hokolomopo
[IMP] edition: add extra rows for spreading formulas
4b6ebe4 
The goal of this commit is to add extra rows to the spreadsheet when
the user create a new spreading formula, but there is not enough rows
for the formula to spread.

closes #3005

Task: 3458203
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Feb 29, 2024
@robodoo robodoo added the 17.2 label Feb 29, 2024
@fw-bot fw-bot deleted the master-insert-row-for-spreading-formula-adrm branch March 14, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasLefevre LucasLefevre LucasLefevre approved these changes

Assignees
No one assigned
Labels
17.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hokolomopo @robodoo @LucasLefevre