-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] Selection: exclude hidden rows/cols in selection statistics #3010
[FW][FIX] Selection: exclude hidden rows/cols in selection statistics #3010
Conversation
@dhrp-odoo @LucasLefevre cherrypicking of pull request #2966 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
02cfba1
to
88f3dd5
Compare
Hi @LucasLefevre, I have resolved the merged conflicts and made some changes to the code. The reason for these changes is that in version 16.1, we returned an evaluated cell by mapping over zones, which doesn't have any info such as an ID or any other identifier to determine the column and row for filtering hidden rows. Can you review these changes once again? Thanks :) |
88f3dd5
to
ead0f56
Compare
src/plugins/ui_stateful/selection.ts
Outdated
for (let col = zone.left; col <= zone.right; col++) { | ||
for (let row = zone.top; row <= zone.bottom; row++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestion to avoid one nested level and with a more declarative approach.
LGTM otherwise :)
for (let col = zone.left; col <= zone.right; col++) { | |
for (let row = zone.top; row <= zone.bottom; row++) { | |
for (const { col, row } of positions(zone)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LucasLefevre, I have implemented the suggested changes. Thanks :)
Previously, the Selection Statistics displayed calculations for all rows and columns, even when some were hidden. This commit addresses the issue by considering only the cells that are not hidden in the statistics calculation. Task: 3508872 X-original-commit: 56d9f38
ead0f56
to
4a34868
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robodoo r+
Thanks !
Previously, the Selection Statistics displayed calculations for all rows and columns, even when some were hidden. This commit addresses the issue by considering only the cells that are not hidden in the statistics calculation. closes #3010 Task: 3508872 X-original-commit: 56d9f38 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Description:
Previously, the Selection Statistics displayed calculations for all rows and columns, even when some were hidden.
This commit addresses the issue by considering only the cells that are not hidden in the statistics calculation.
Task: : 3508872
review checklist
Forward-Port-Of: #2966