Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] Highlight: prevent default mousedown behaviour #3060

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Oct 24, 2023

Just like in commit a3b2e7c, we need to prevent the default mousedown behaviour while interacting with the HighlightComponent as it can be active at the same time as the Composer.

Task: /

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3059

Just like in commit a3b2e7c, we need to prevent the default mousedown
behaviour while interacting with the `Highlight`Component as it can be
active at the same time as the `Composer`.

Task: /
X-original-commit: 457b8c7
@robodoo
Copy link
Collaborator

robodoo commented Oct 24, 2023

@fw-bot
Copy link
Collaborator Author

fw-bot commented Oct 24, 2023

This PR targets saas-16.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

robodoo pushed a commit that referenced this pull request Oct 24, 2023
Just like in commit a3b2e7c, we need to prevent the default mousedown
behaviour while interacting with the `Highlight`Component as it can be
active at the same time as the `Composer`.

closes #3060

Task: /
X-original-commit: 457b8c7
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
@robodoo robodoo temporarily deployed to merge October 24, 2023 12:09 Inactive
@robodoo robodoo closed this Oct 24, 2023
@fw-bot fw-bot deleted the saas-16.2-saas-16.1-highlight-default-rar-JKJH-fw branch November 7, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants