-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][IMP] scorecard: handling CF font style on chart #3099
[FW][IMP] scorecard: handling CF font style on chart #3099
Conversation
@somu-odoo @LucasLefevre cherrypicking of pull request #3029 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Before this commit: Any applied CF font color on key cell would not reflect on chart After this commit: Text color of Key Value will reflect as follows: - If no font color is set, then default text color will be applied. - If CF font color is applied on cell, key value will reflect that text color. - If user sets a font color on cell, then user applied color of key value will take precedence over CF font color "getStyleOfSingleCellChart" method of evaluation chart is modified to "getBackgroundOfSingleCellChart", which handles style of a single cell for chart at runtime . Task - 3543131 X-original-commit: 37800cb
3c5bf3f
to
689cd12
Compare
@LucasLefevre resolved the conflict. Although should I create a PR for 17.0 or are we merging it in all versions of 16.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although should I create a PR for 17.0 or are we merging it in all versions of 16.0?
let's keep this fix/imp for this time.
robodoo r+
Before this commit: Any applied CF font color on key cell would not reflect on chart After this commit: Text color of Key Value will reflect as follows: - If no font color is set, then default text color will be applied. - If CF font color is applied on cell, key value will reflect that text color. - If user sets a font color on cell, then user applied color of key value will take precedence over CF font color "getStyleOfSingleCellChart" method of evaluation chart is modified to "getBackgroundOfSingleCellChart", which handles style of a single cell for chart at runtime . Task - 3543131 closes #3099 X-original-commit: 37800cb Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Description:
Before:
Any applied CF font color on key cell would not reflect on chart
After:
Text color of Key Value will reflect as follows:
will take precedence over CF font color
"getStyleOfSingleCellChart" method of evaluation chart is modified to
"getBackgroundOfSingleCellChart", which handles style of a single cell
for chart at runtime .
Task: : 3543131
review checklist
Forward-Port-Of: #3029