Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] F&R: Fix css rule #3153

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 14, 2023

The padding rule did not respect the web standards. It just happened to
work on our demo sheet because the page is run in quirks mode, a
mode that support web pages prior to the instoduction of the web
standards. This rule probably never worked when the component was
embedded in a "modern" web page.

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3142
Forward-Port-Of: #3140

The padding rule did not respect the web standards. It just happened to
work on our demo sheet because the page is run in quirks mode, a
mode that support web pages prior to the instoduction of the web
standards. This rule probably never worked when the component was
embedded in a "modern" web page.

X-original-commit: 4db9ded
@robodoo
Copy link
Collaborator

robodoo commented Nov 14, 2023

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 14, 2023

This PR targets saas-16.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot fw-bot mentioned this pull request Nov 14, 2023
14 tasks
robodoo pushed a commit that referenced this pull request Nov 14, 2023
The padding rule did not respect the web standards. It just happened to
work on our demo sheet because the page is run in quirks mode, a
mode that support web pages prior to the instoduction of the web
standards. This rule probably never worked when the component was
embedded in a "modern" web page.

closes #3153

X-original-commit: 4db9ded
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo closed this Nov 14, 2023
@fw-bot fw-bot deleted the saas-16.1-17.0-fix-css-rar-zd5G-fw branch November 28, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants