[FW][FIX] FilterEvaluationPlugin: insert/remove row on data filter header #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two issues in the FilterEvaluationPlugin: 1. Previously, when inserting a row above or below a data filter header, hidden rows inside the data filter were not being updated, causing a state inconsistency issue. This commit ensures that hidden rows inside the data filter header are correctly updated when rows are inserted above or below the header. 2. Another issue occurred when removing a row above the data filter header while certain rows were filtered. This led to a mismatch in the data filter state, revealing hidden rows. This commit fixes this problem by updating the handling of hidden rows inside the data filter header during row removal. Task: 3546012 X-original-commit: 841da08
Previously, removing rows that included the filter header failed to remove the associated data filter tables. This commit addresses the issue by ensuring the data filter tables is also removed when rows with the filter header are deleted. Task: 3546012 X-original-commit: d15825d
|
This PR targets saas-16.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Nov 16, 2023
This commit addresses two issues in the FilterEvaluationPlugin: 1. Previously, when inserting a row above or below a data filter header, hidden rows inside the data filter were not being updated, causing a state inconsistency issue. This commit ensures that hidden rows inside the data filter header are correctly updated when rows are inserted above or below the header. 2. Another issue occurred when removing a row above the data filter header while certain rows were filtered. This led to a mismatch in the data filter state, revealing hidden rows. This commit fixes this problem by updating the handling of hidden rows inside the data filter header during row removal. Task: 3546012 X-original-commit: 841da08 Part-of: #3159
robodoo
pushed a commit
that referenced
this pull request
Nov 16, 2023
Previously, removing rows that included the filter header failed to remove the associated data filter tables. This commit addresses the issue by ensuring the data filter tables is also removed when rows with the filter header are deleted. closes #3159 Task: 3546012 X-original-commit: d15825d Signed-off-by: Rémi Rahir (rar) <rar@odoo.com> Signed-off-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
fw-bot
deleted the
saas-16.2-16.0-fix-insert-row-data-filter-header-dhrp-jp1q-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes two distinct commits that address issues related to the handling of data filter headers in our SheetPlugin and FilterEvaluationPlugin.
Commit 1: [FIX] FilterEvaluationPlugin: insert/remove row on data filter header
Previously, when inserting a row above or below a data filter header, hidden rows inside the data filter were not being updated. This caused a state inconsistency issue between the data filter header and the data filter values.
This commit address the problem by ensuring that hidden rows inside the data filter header are correctly updated when rows are inserted above or below the data filter header.
Another issue occurred when removing a row above the data filter header while certain rows were filtered. This led to a mismatch in the data filter state, revealing hidden rows.
This commit fixes this problem by updating the handling of hidden rows inside the data filter header during row removal.
Commit 2: [FIX] SheetPlugin: removing row with data filter header
Task: : 3546012
review checklist
Forward-Port-Of: #3113
Forward-Port-Of: #3031