[FW][FIX] model: don't flatten command result #3195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`array.flat()` is slow because it creates a new array (and allocates memory) With this commit, we only execute `array.flat()` if the command as been refused by one of the plugins (for possibly several resons) `checkDispatchAllowed` self-time could take up to 4% of the total time when loading a spreadsheet with lots of initial revisions. Now it's 0.0% :) X-original-commit: 4991b29
|
This PR targets saas-16.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@LucasLefevre @rrahir the next pull request (#3196) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 17, 2023
`array.flat()` is slow because it creates a new array (and allocates memory) With this commit, we only execute `array.flat()` if the command as been refused by one of the plugins (for possibly several resons) `checkDispatchAllowed` self-time could take up to 4% of the total time when loading a spreadsheet with lots of initial revisions. Now it's 0.0% :) closes #3195 X-original-commit: 4991b29 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
array.flat()is slow because it creates a new array (and allocates memory)With this commit, we only execute
array.flat()if the command as been refused by one of the plugins (for possibly several resons)checkDispatchAllowedself-time could take up to 4% of the total time when loading a spreadsheet with lots of initial revisions.Now it's 0.0% :)
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist
Forward-Port-Of: #3169