Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][FIX] cells: faster getter to get cell #3200

Closed
wants to merge 1 commit into from
Closed

[FW][FIX] cells: faster getter to get cell #3200

wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 17, 2023

Description:

getCellById self-time was ~13.6% and is now ~9.1% (average over 5 runs)

Task: : 3588401

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3189
Forward-Port-Of: #3184

@LucasLefevre
[FIX] cells: faster getter to get cell
977ced0 
getCellById self-time was ~13.6% and is now ~9.1% (average over 5 runs)

opw-3588401

Task: 3588401
X-original-commit: f01711b
@robodoo
Copy link
Collaborator

robodoo commented Nov 17, 2023

Pull request status dashboard.

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 17, 2023

This PR targets saas-16.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot fw-bot mentioned this pull request Nov 17, 2023
Closed
14 tasks
robodoo pushed a commit that referenced this pull request Nov 17, 2023
@LucasLefevre
[FIX] cells: faster getter to get cell
8b2e6a9 
getCellById self-time was ~13.6% and is now ~9.1% (average over 5 runs)

opw-3588401

closes #3200

Task: 3588401
X-original-commit: f01711b
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Nov 17, 2023
@fw-bot fw-bot deleted the saas-16.2-15.0-faster-get-cell-lul-HSCS-fw branch December 1, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
forwardport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fw-bot @robodoo @LucasLefevre