Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] cells,borders: cancel useless commands #3218

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 20, 2023

Try to move a column with lots of empty cells: there are lots and lots of SET_BORDERS and CLEAR_CELL commands which are doing nothing because there are no borders to set or the cell is already cleared.

If the column has thousands of rows, the revision size is be huuuged, with thousands of useless commands.
Reducing the size improves: network payload size and the loading of initial revisions.

With this commit, the useless SET_BORDERS and CLEAR_CELL commands are cancelled (and therefore never part of the revision)

Task: 3603259

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3217

@robodoo
Copy link
Collaborator

robodoo commented Nov 20, 2023

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 20, 2023

@rrahir cherrypicking of pull request #3217 failed.

stdout:

Auto-merging src/plugins/core/borders.ts
CONFLICT (content): Merge conflict in src/plugins/core/borders.ts
Auto-merging src/plugins/core/cell.ts
CONFLICT (content): Merge conflict in src/plugins/core/cell.ts
Auto-merging src/types/commands.ts
Auto-merging tests/plugins/borders.test.ts
Auto-merging tests/plugins/cell.test.ts
CONFLICT (content): Merge conflict in tests/plugins/cell.test.ts
Auto-merging tests/test_helpers/commands_helpers.ts

stderr:

17:11:34.598753 git.c:463               trace: built-in: git cherry-pick 45ccdbf4e2b3818370cc3faf2642aa1da382cf76
error: could not apply 45ccdbf4e... [FIX] cells,borders: cancel useless commands
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Try to move a column with lots of empty cells: there are lots and lots
of SET_BORDERS and CLEAR_CELL commands which are doing nothing because
there are no borders to set or the cell is already cleared.

If the column has thousands of rows, the revision size is be huuuged, with
thousands of useless commands.
Reducing the size improves: network payload size and the loading of initial
revisions.

With this commit, the useless SET_BORDERS and CLEAR_CELL commands are
cancelled (and therefore never part of the revision)

Task: 3603259
X-original-commit: 620a331
@rrahir rrahir force-pushed the saas-16.1-16.0-cancel-borders-lul-j9eY-fw branch from 3063fe3 to 23c0e48 Compare November 20, 2023 20:37
@rrahir
Copy link
Collaborator

rrahir commented Nov 20, 2023

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 20, 2023
Try to move a column with lots of empty cells: there are lots and lots
of SET_BORDERS and CLEAR_CELL commands which are doing nothing because
there are no borders to set or the cell is already cleared.

If the column has thousands of rows, the revision size is be huuuged, with
thousands of useless commands.
Reducing the size improves: network payload size and the loading of initial
revisions.

With this commit, the useless SET_BORDERS and CLEAR_CELL commands are
cancelled (and therefore never part of the revision)

closes #3218

Task: 3603259
X-original-commit: 620a331
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo closed this Nov 20, 2023
@fw-bot fw-bot deleted the saas-16.1-16.0-cancel-borders-lul-j9eY-fw branch December 4, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants