[FW][FIX] cells,borders: cancel useless commands #3218
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to move a column with lots of empty cells: there are lots and lots of SET_BORDERS and CLEAR_CELL commands which are doing nothing because there are no borders to set or the cell is already cleared.
If the column has thousands of rows, the revision size is be huuuged, with thousands of useless commands.
Reducing the size improves: network payload size and the loading of initial revisions.
With this commit, the useless SET_BORDERS and CLEAR_CELL commands are cancelled (and therefore never part of the revision)
Task: 3603259
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist
Forward-Port-Of: #3217