[FW][FIX] various perf improvements #3257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`updateRowsStructureOnDeletion` has several problems: - it uses `array.shift()` which very slow - it's called for every deleted rows even though it could delete several rows at once On the large dataset demo spreadsheet (10k rows), deleting the last 1400 rows goes from 2.5s to less than 2ms X-original-commit: 497115b
`updateRowsStructureOnAddition` is doing nothing. It maps the cells in `sheet.rows` to an array, then reassign this array to `sheet.rows`. It wasn't slow (even with the `.shift()`; it was only called once) but `updateRowsStructureOnAddition` is still infinitely faster than before. X-original-commit: cc73a36
|
This PR targets saas-16.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Nov 24, 2023
`updateRowsStructureOnDeletion` has several problems: - it uses `array.shift()` which very slow - it's called for every deleted rows even though it could delete several rows at once On the large dataset demo spreadsheet (10k rows), deleting the last 1400 rows goes from 2.5s to less than 2ms X-original-commit: 497115b Part-of: #3257
robodoo
pushed a commit
that referenced
this pull request
Nov 24, 2023
`updateRowsStructureOnAddition` is doing nothing. It maps the cells in `sheet.rows` to an array, then reassign this array to `sheet.rows`. It wasn't slow (even with the `.shift()`; it was only called once) but `updateRowsStructureOnAddition` is still infinitely faster than before. closes #3257 X-original-commit: cc73a36 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist
Forward-Port-Of: #3234