-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] export: faster border and style export #3262
Conversation
@LucasLefevre @hokolomopo cherrypicking of pull request #3248 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
11dfa2e
to
cb118ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robodoo r+
cb118ef
to
8d2ef4a
Compare
`deepEquals` is faster than comparing the stringified values. On a sheet provided RNG, `getBorderId` goes from ~1.4s to ~250ms There was also a bug in the border export code. `stringify` filter nested object keys (because of the ). { top: { style: "thin", color: "#000" }, } would give { top: {}} I'm removing the `stringified` function because it not used anymore and it doesn't work as expected. X-original-commit: ad487d3
8d2ef4a
to
57edffc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robodoo r+
`deepEquals` is faster than comparing the stringified values. On a sheet provided RNG, `getBorderId` goes from ~1.4s to ~250ms There was also a bug in the border export code. `stringify` filter nested object keys (because of the ). { top: { style: "thin", color: "#000" }, } would give { top: {}} I'm removing the `stringified` function because it not used anymore and it doesn't work as expected. closes #3262 X-original-commit: ad487d3 Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Description:
deepEquals
is faster than comparing the stringified values. On a sheet provided by RNG,getBorderId
goes from ~1.4s to ~250msTask: : TASK_ID
review checklist
Forward-Port-Of: #3254
Forward-Port-Of: #3248