Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] Autofill: Automatic autofill based on content #3278

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 28, 2023

The Automatic autofill is supposed to consider the cells that are seemingly empty be still have some content (for instance, a formula resulting in an empty string). The behaviour was broken when we refactored the evaluation in saas-16.1.

Note that the current fix will no longer be correct once the spreading formulas will be introduced.

Task: 3592859

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3214

The Automatic autofill is supposed to consider the cells that are
seemingly empty be still have some content (for instance, a formula resulting in
an empty string). The behaviour was broken when we refactored the evaluation
in `saas-16.1`.

Note that the current fix will no longer be correct once the spreading formulas
will be introduced.

Task: 3592859
X-original-commit: e7bd110
@robodoo
Copy link
Collaborator

robodoo commented Nov 28, 2023

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 28, 2023

This PR targets saas-16.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

robodoo pushed a commit that referenced this pull request Nov 28, 2023
The Automatic autofill is supposed to consider the cells that are
seemingly empty be still have some content (for instance, a formula resulting in
an empty string). The behaviour was broken when we refactored the evaluation
in `saas-16.1`.

Note that the current fix will no longer be correct once the spreading formulas
will be introduced.

closes #3278

Task: 3592859
X-original-commit: e7bd110
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Nov 28, 2023
@fw-bot fw-bot deleted the saas-16.3-saas-16.1-fix-autofill-auto-rar-g_rw-fw branch December 12, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants