Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] tests: enables type checking for binded functions #3408

Closed
wants to merge 1 commit into from

Conversation

LucasLefevre
Copy link
Collaborator

Description:

Starting in saas-16.2, the tsconfig for tests isn't based on the general tsconfig.json file anymore.

The change of commit b04fd21 was not reflected in
the test config file.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Starting in saas-16.2, the tsconfig for tests isn't
based on the general tsconfig.json file anymore.

The change of commit b04fd21 was not reflected in
the test config file.
@robodoo
Copy link
Collaborator

robodoo commented Jan 9, 2024

@rrahir
Copy link
Collaborator

rrahir commented Jan 9, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 9, 2024
Starting in saas-16.2, the tsconfig for tests isn't
based on the general tsconfig.json file anymore.

The change of commit b04fd21 was not reflected in
the test config file.

closes #3408

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo closed this Jan 9, 2024
@fw-bot fw-bot deleted the saas-16.2-check-binded-function-lul branch January 23, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants