Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] evaluation: evaluateFormula no longer throws #3439

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 15, 2024

The getter evaluateFormula required to be wrapped in a try/catch statement to handle the evaluation errors but as this is quite error prone, we decided to change it to no longer throw. The getter will instead the value of the error that was previously thrown.

Task: 3670818

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3393

@robodoo
Copy link
Collaborator

robodoo commented Jan 15, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 15, 2024

@rrahir @LucasLefevre cherrypicking of pull request #3393 failed.

stdout:

Auto-merging src/plugins/ui/evaluation.ts
CONFLICT (content): Merge conflict in src/plugins/ui/evaluation.ts
Auto-merging src/plugins/ui/evaluation_conditional_format.ts
Auto-merging tests/formulas/compiler.test.ts
CONFLICT (content): Merge conflict in tests/formulas/compiler.test.ts
Auto-merging tests/xlsx.test.ts

stderr:

10:25:53.647551 git.c:463               trace: built-in: git cherry-pick 5897cb5d9734d52b88fbcf5f03a1966ddf648a7a
error: could not apply 5897cb5d9... [FIX] evaluation: `evaluateFormula` no longer throws
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

The getter `evaluateFormula` required to be wrapped in a try/catch
statement to handle the evaluation errors but as this is quite error
prone, we decided to change it to no longer throw. The getter will
instead the "#ERROR" string.

Task: 3670818
X-original-commit: 485a383
@rrahir rrahir force-pushed the saas-15.2-15.0-evaluateFormula-no-throw-rar-iim0-fw branch from 06e6743 to 173213e Compare January 15, 2024 12:04
@rrahir
Copy link
Collaborator

rrahir commented Jan 15, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 15, 2024
The getter `evaluateFormula` required to be wrapped in a try/catch
statement to handle the evaluation errors but as this is quite error
prone, we decided to change it to no longer throw. The getter will
instead the "#ERROR" string.

closes #3439

Task: 3670818
X-original-commit: 485a383
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo closed this Jan 15, 2024
@fw-bot fw-bot deleted the saas-15.2-15.0-evaluateFormula-no-throw-rar-iim0-fw branch January 29, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants