New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] side_panel: cf rule range bugs #3446
Closed
fw-bot
wants to merge
1
commit into
saas-16.2
from
saas-16.2-16.0-fix-side-panel-range-bugs-khpa-JPLs-fw
Closed
[FW][FIX] side_panel: cf rule range bugs #3446
fw-bot
wants to merge
1
commit into
saas-16.2
from
saas-16.2-16.0-fix-side-panel-range-bugs-khpa-JPLs-fw
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
@khpa-odoo @rrahir cherrypicking of pull request #3413 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Steps to reproduce :- Bug 1 : - Change the range to "" - Focus out => selection input should have a red border even without clicking on confirm Bug 2 : - Enter "" as range and save - Now change it to a valid range and confirm => red border and error message do not disappear even if you confirm Bug 3 : - Enter an invalid range (eg. A2:B3:C3) and save - Now change it to a valid range and confirm => red border disappears but the error message does not disappear Bug 4 : - Enter an invalid range (with invalid sheet name) => red border appears (correct), but there is no error message and you can still save the cf rule With this commit, the following amendments have been made: Earlier, the condition checked to display selection input border in red considered 'empty range' as a valid input. That condition is changed to consider it as an invalid range. The condition to check for invalid ranges, while dispatching command result 'InvalidRange', is altered to use the getter `isRangeValid` so that cf rules with ranges containing invalid sheet name cannot be saved. To ensure that the error message appears if and only if the input is invalid (i.e. it disappears on entering a valid range as input, even without clicking on confirm or save), error messages for invalid range are now handled from the `onRangesChanged` method instead of `saveConditionalFormat` method. Task ID : 3651293 X-original-commit: 4a956f3
rrahir
force-pushed
the
saas-16.2-16.0-fix-side-panel-range-bugs-khpa-JPLs-fw
branch
from
January 16, 2024 08:41
d84142a
to
19b1c8c
Compare
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 16, 2024
Steps to reproduce :- Bug 1 : - Change the range to "" - Focus out => selection input should have a red border even without clicking on confirm Bug 2 : - Enter "" as range and save - Now change it to a valid range and confirm => red border and error message do not disappear even if you confirm Bug 3 : - Enter an invalid range (eg. A2:B3:C3) and save - Now change it to a valid range and confirm => red border disappears but the error message does not disappear Bug 4 : - Enter an invalid range (with invalid sheet name) => red border appears (correct), but there is no error message and you can still save the cf rule With this commit, the following amendments have been made: Earlier, the condition checked to display selection input border in red considered 'empty range' as a valid input. That condition is changed to consider it as an invalid range. The condition to check for invalid ranges, while dispatching command result 'InvalidRange', is altered to use the getter `isRangeValid` so that cf rules with ranges containing invalid sheet name cannot be saved. To ensure that the error message appears if and only if the input is invalid (i.e. it disappears on entering a valid range as input, even without clicking on confirm or save), error messages for invalid range are now handled from the `onRangesChanged` method instead of `saveConditionalFormat` method. Task ID : 3651293 closes #3446 X-original-commit: 4a956f3 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
14 tasks
14 tasks
fw-bot
deleted the
saas-16.2-16.0-fix-side-panel-range-bugs-khpa-JPLs-fw
branch
January 30, 2024 09:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Steps to reproduce :-
Bug 1 :
confirm
Bug 2 :
not disappear even if you confirm
Bug 3 :
error message does not disappear
Bug 4 :
(correct), but there is no error message and you can still save the cf rule
With this commit the following amendments have been made:
Earlier, the condition checked to display selection input border in red
considered 'empty range' as a valid input. That condition is changed to
consider it as an invalid range.
The condition to check for invalid ranges, while dispatching command result
'InvalidRange', is altered to use the getter
isRangeValid
so that cf ruleswith ranges containing invalid sheet name cannot be saved.
To ensure that the error message appears if and only if the input is invalid
(i.e. it disappears on entering a valid range as input, even without clicking on
confirm or save), error messages for invalid range are now handled from
the
onRangesChanged
method instead ofsaveConditionalFormat
method.Task: : 3651293
review checklist
Forward-Port-Of: #3413