Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] format: fix chaining of FORMAT.LARGE.NUMBER #3476

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 19, 2024

Description

Chaining FORMAT.LARGE.NUMBER formulas was adding the postfix multiple times. This commit fixes the issue by adding a check to see if the postfix is already present.

Task: : 3633947

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3358

Chaining FORMAT.LARGE.NUMBER formulas was adding the postfix multiple
times. This commit fixes the issue by adding a check to see if the
postfix is already present.

Task: 3633947
X-original-commit: b3affc5
@robodoo
Copy link
Collaborator

robodoo commented Jan 19, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 19, 2024

This PR targets saas-16.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@hokolomopo
Copy link
Contributor

@fw-bot r+

robodoo pushed a commit that referenced this pull request Jan 23, 2024
Chaining FORMAT.LARGE.NUMBER formulas was adding the postfix multiple
times. This commit fixes the issue by adding a check to see if the
postfix is already present.

closes #3476

Task: 3633947
X-original-commit: b3affc5
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
@robodoo robodoo closed this Jan 23, 2024
@fw-bot fw-bot deleted the saas-16.1-16.0-fix-format-larg-numer-chaining-adrm-1I6l-fw branch February 6, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants