[FW][FIX] evaluation: behavior for invalid range arguments #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@khpa-odoo @pro-odoo cherrypicking of pull request #3361 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
khpa-odoo
force-pushed
the
saas-15.2-15.0-fix-invalid-range-args-khpa-UVEK-fw
branch
from
307bb8a
to
5aa4a8e
Compare
|
@pro-odoo Resolved the conflict 👍 |
pro-odoo
reviewed
Jan 23, 2024
src/plugins/ui/evaluation.ts
Outdated
Comment on lines
193
to
194
| if (getters.getSheet(range.sheetId)) { | ||
| cell = getters.getCell(range.sheetId, range.zone.left, range.zone.top); |
There was a problem hiding this comment.
Because we used the getter getSheet in the fix for 15.0 and saas-15.1. It checks for the same condition and throws the error as well. So I made this change for both consistency and optimization. However, I can undo it if you want me to : )
@pro-odoo
There was a problem hiding this comment.
Yes, you can undo this change. It's easier to know why we try to get the sheet.
When user provides an invalid sheet name in range arguments of a function, it performs computations on data of specified range from active sheet by default and returns misleading results. This commit changes the behavior to throw an error instead of performing any kind of computations. Task ID : 3619144 X-original-commit: 5eedbd0
khpa-odoo
force-pushed
the
saas-15.2-15.0-fix-invalid-range-args-khpa-UVEK-fw
branch
from
5aa4a8e
to
2a2c07f
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 25, 2024
When user provides an invalid sheet name in range arguments of a function, it performs computations on data of specified range from active sheet by default and returns misleading results. This commit changes the behavior to throw an error instead of performing any kind of computations. Task ID : 3619144 closes #3492 X-original-commit: 5eedbd0 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When user provides an invalid sheet name in range arguments of a function, it performs computations on
data of specified range from active sheet by default and returns misleading results.
This PR changes the behavior to throw an error instead of performing any kind of computations.
Task: : 3619144
review checklist
Forward-Port-Of: #3361