[IMP] chart: improve pie chart #3545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhe-odoo
force-pushed
the
master-chart-improvements-anhe
branch
4 times, most recently
from
949e009
to
7029aaf
Compare
anhe-odoo
commented
Feb 1, 2024
anhe-odoo
force-pushed
the
master-chart-improvements-anhe
branch
from
7029aaf
to
48e60fd
Compare
hokolomopo
reviewed
Feb 6, 2024
There was a problem hiding this comment.
ChartJS sounds like black magic 🧙
Do you think it would simplify things if instead of highlighting the hovered pie part by making every other part transparent, you would use "easier" chartJs features to make the hovered items darker/add a border/make in bigger (this ) ?
You'd still need to do magic when hovering the legend tho...
src/components/side_panel/chart/building_blocks/label_range/label_range.ts
Outdated
Show resolved
Hide resolved
anhe-odoo
force-pushed
the
master-chart-improvements-anhe
branch
2 times, most recently
from
33365e8
to
65708b2
Compare
hokolomopo
reviewed
Feb 8, 2024
anhe-odoo
force-pushed
the
master-chart-improvements-anhe
branch
from
65708b2
to
bb60e10
Compare
anhe-odoo
force-pushed
the
master-chart-improvements-anhe
branch
from
bb60e10
to
5cf4ddd
Compare
anhe-odoo
force-pushed
the
master-chart-improvements-anhe
branch
from
5cf4ddd
to
bc812ad
Compare
rrahir
reviewed
Feb 29, 2024
src/components/side_panel/chart/building_blocks/label_range/label_range.ts
Outdated
Show resolved
Hide resolved
rrahir
reviewed
Mar 1, 2024
| @@ -197,6 +204,56 @@ export class PieChart extends AbstractChart { | |||
| const definition = this.getDefinitionWithSpecificDataSets(dataSets, labelRange); | |||
| return new PieChart(definition, this.sheetId, this.getters); | |||
| } | |||
|
|
|||
| highlightItem(index: number, dataSets) { | |||
LucasLefevre
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Some comments/suggestions on the first commit :)
The second commit looks like a lot of code for a limited value. I also don't really understand why the datasets should be highlighted for pie charts but not other charts.
I think I'd cancel this part (see message in the task chatter)
src/components/side_panel/chart/building_blocks/label_range/label_range.ts
Outdated
Show resolved
Hide resolved
src/components/side_panel/chart/line_chart/line_chart_config_panel.ts
Outdated
Show resolved
Hide resolved
src/components/side_panel/chart/scatter_chart/scatter_chart_config_panel.ts
Outdated
Show resolved
Hide resolved
anhe-odoo
force-pushed
the
master-chart-improvements-anhe
branch
2 times, most recently
from
7152909
to
95f249b
Compare
LucasLefevre
reviewed
Mar 5, 2024
anhe-odoo
force-pushed
the
master-chart-improvements-anhe
branch
from
95f249b
to
a1af3af
Compare
LucasLefevre
reviewed
Mar 7, 2024
Comment on lines
100
to
105
| const zone = toUnboundedZone(this.dataSeriesRanges[0]); | ||
| disabled = | ||
| zone.left !== undefined && | ||
| zone.right !== undefined && | ||
| zone.left === zone.right && | ||
| this.labelRange === this.dataSeriesRanges[0]; |
There was a problem hiding this comment.
actually, I'm not sure why we should prevent the user to uncheck the aggregate.
Task Description This commit implements the ability for the user to plot a pie chart only based on the count of strings in the datasets. The bar and scatter chart has also been updated to take into account the aggregated options when changing chart type, so that the string occurence is kept when switching chart type from the side pannel. Related Task: Task: 3370683
anhe-odoo
force-pushed
the
master-chart-improvements-anhe
branch
from
a1af3af
to
5bc91df
Compare
robodoo
pushed a commit
that referenced
this pull request
Mar 7, 2024
Task Description This commit implements the ability for the user to plot a pie chart only based on the count of strings in the datasets. The bar and scatter chart has also been updated to take into account the aggregated options when changing chart type, so that the string occurence is kept when switching chart type from the side pannel. Related Task: closes #3545 Task: 3370683 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description
The aims of this task is to improve the user experience when creating a pie chart :
Related Task:
review checklist