[FW][FIX] Charts: fix incoherent panel state #3576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets saas-16.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@anhe-odoo @LucasLefevre ci/runbot failed on this forward-port PR |
Task Description This task aims to adress some issues in the side pannel of a chart: 1. When having only one point in a dataseries and selecting "First row as header", the point dissapear from the chart (legit), but we don't have the possibility to uncheck this checkbox. 2. When having a normal dataset and another dataset containing one point, checking the "... as header" checkbox works has expected, but unchecking it don't make the 'one-point' dataset come back Related Task: Task: 3380568 X-original-commit: f2a59c9
anhe-odoo
force-pushed
the
saas-16.3-master-chart-incoherent_panel_state-anhe-n4mO-fw
branch
from
4c8d492
to
7ff7295
Compare
|
@anhe-odoo @LucasLefevre this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo) |
robodoo
pushed a commit
that referenced
this pull request
Feb 1, 2024
Task Description This task aims to adress some issues in the side pannel of a chart: 1. When having only one point in a dataseries and selecting "First row as header", the point dissapear from the chart (legit), but we don't have the possibility to uncheck this checkbox. 2. When having a normal dataset and another dataset containing one point, checking the "... as header" checkbox works has expected, but unchecking it don't make the 'one-point' dataset come back Related Task: closes #3576 Task: 3380568 X-original-commit: f2a59c9 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
14 tasks
fw-bot
deleted the
saas-16.3-master-chart-incoherent_panel_state-anhe-n4mO-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This task aims to address some issues in the side panel of a chart:
row as header", the point disappear from the chart (legit), but
we don't have the possibility to uncheck this checkbox.
point, checking the "... as header" checkbox works has expected, but
unchecking it don't make the 'one-point' dataset come back
Related Task:
Task: 3380568
Related Task(s):
Review Checklist
Forward-Port-Of: #3544
Forward-Port-Of: #2929