[FIX] Find and replace: draw search results #3609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hokolomopo
force-pushed
the
master-find-and-replace-highlight-fix-adrm
branch
2 times, most recently
from
a64a508
to
17540db
Compare
src/components/side_panel/find_and_replace/find_and_replace_store.ts
Outdated
Show resolved
Hide resolved
hokolomopo
force-pushed
the
master-find-and-replace-highlight-fix-adrm
branch
2 times, most recently
from
809c526
to
8d9b266
Compare
src/components/side_panel/find_and_replace/find_and_replace_store.ts
Outdated
Show resolved
Hide resolved
The search results were not drawn since transforming the f&r plugin with a store (we defined a `draw` instead of a `drawLayer` method). Took the opportunity to draw to use the `HighlightStore` to draw the search results instead of doing it manually. Task: 3721321
hokolomopo
force-pushed
the
master-find-and-replace-highlight-fix-adrm
branch
from
8d9b266
to
3796f76
Compare
robodoo
pushed a commit
that referenced
this pull request
Feb 29, 2024
The search results were not drawn since transforming the f&r plugin with a store (we defined a `draw` instead of a `drawLayer` method). Took the opportunity to draw to use the `HighlightStore` to draw the search results instead of doing it manually. closes #3609 Task: 3721321 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search results were not drawn since transforming the f&r plugin with a store (we defined a
drawinstead of adrawLayermethod).Took the opportunity to draw to use the
HighlightStoreto draw the search results instead of doing it manually.Description:
description of this task, what is implemented and why it is implemented that way.
Task: : 3721321
review checklist