Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] autofill: allow to autofill a mix of number values and formulas #3617

Closed
wants to merge 1 commit into from
Closed

[FIX] autofill: allow to autofill a mix of number values and formulas #3617

wants to merge 1 commit into from

Conversation

laa-odoo
Copy link
Collaborator

@laa-odoo laa-odoo commented Feb 6, 2024 •
edited

Description:

The previous code did not allow autofilling a selection with numbers coming from both simple inputs and formulas.

This commit fix that

Task: : 3700733

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@laa-odoo
[FIX] autofill: allow to autofill a mix of number values and formulas
689c6bd 
The previous code did not allow autofilling a selection
with numbers coming from both simple inputs and formulas.

This commit fix that

Task: 3700733
@robodoo
Copy link
Collaborator

robodoo commented Feb 6, 2024

Pull request status dashboard.

LucasLefevre
LucasLefevre approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 23, 2024
@laa-odoo
[FIX] autofill: allow to autofill a mix of number values and formulas
7074c66 
The previous code did not allow autofilling a selection
with numbers coming from both simple inputs and formulas.

This commit fix that

closes #3617

Task: 3700733
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@fw-bot fw-bot mentioned this pull request Feb 23, 2024
Closed
14 tasks
@robodoo robodoo closed this Feb 23, 2024
@fw-bot
Copy link
Collaborator

fw-bot commented Feb 27, 2024

@laa-odoo @LucasLefevre this pull request has forward-port PRs awaiting action (not merged or closed):

2 similar comments
@fw-bot
Copy link
Collaborator

fw-bot commented Feb 28, 2024

@laa-odoo @LucasLefevre this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented Feb 29, 2024

@laa-odoo @LucasLefevre this pull request has forward-port PRs awaiting action (not merged or closed):

This was referenced Feb 29, 2024
Closed
Closed
Closed
Closed
Closed
@fw-bot fw-bot deleted the saas-16.1-fix-autofill-when-number-and-formula-laa branch March 8, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasLefevre LucasLefevre LucasLefevre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@laa-odoo @robodoo @fw-bot @LucasLefevre