-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] export: unbound formula stays unbound in snapshots #3622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@VincentSchippefilt @rrahir cherrypicking of pull request #3614 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. X-original-commit: 0ed2720
67a8f32
to
1850c8e
Compare
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. closes #3622 X-original-commit: 0ed2720 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com> Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
14 tasks
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Apr 27, 2024
The recent fix in #3622 combined with a slight refactoring of the export for Excel in #2090 let to a situation where cells with non-exportable formulas containing references did not have their content replaced by the evaluated result. closes #4146 Task: 3895465 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
14 tasks
robodoo
pushed a commit
that referenced
this pull request
May 3, 2024
The recent fix in #3622 combined with a slight refactoring of the export for Excel in #2090 let to a situation where cells with non-exportable formulas containing references did not have their content replaced by the evaluated result. closes #4147 Task: 3895465 X-original-commit: c8df5d0 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
14 tasks
robodoo
pushed a commit
that referenced
this pull request
May 3, 2024
The recent fix in #3622 combined with a slight refactoring of the export for Excel in #2090 let to a situation where cells with non-exportable formulas containing references did not have their content replaced by the evaluated result. closes #4164 Task: 3895465 X-original-commit: e8d1444 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
14 tasks
14 tasks
robodoo
pushed a commit
that referenced
this pull request
May 3, 2024
The recent fix in #3622 combined with a slight refactoring of the export for Excel in #2090 let to a situation where cells with non-exportable formulas containing references did not have their content replaced by the evaluated result. closes #4167 Task: 3895465 X-original-commit: 0ef57de Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 3, 2024
The recent fix in #3622 combined with a slight refactoring of the export for Excel in #2090 let to a situation where cells with non-exportable formulas containing references did not have their content replaced by the evaluated result. closes #4166 Task: 3895465 X-original-commit: 0ef57de Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot.
This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist
Forward-Port-Of: #3621
Forward-Port-Of: #3614