Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] export: unbound formula stays unbound in snapshots #3622

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Feb 6, 2024

In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot.

This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export.

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3621
Forward-Port-Of: #3614

@robodoo
Copy link
Collaborator

robodoo commented Feb 6, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Feb 6, 2024

@VincentSchippefilt @rrahir cherrypicking of pull request #3614 failed.

stdout:

Auto-merging src/plugins/core/cell.ts
CONFLICT (modify/delete): src/plugins/ui_core_views/evaluation.ts deleted in HEAD and modified in 85c8d1604 ([FIX] export: unbound formula stays unbound in snapshots).  Version 85c8d1604 ([FIX] export: unbound formula stays unbound in snapshots) of src/plugins/ui_core_views/evaluation.ts left in tree.

stderr:

13:27:18.900819 git.c:463               trace: built-in: git cherry-pick 85c8d16043b98e1f1c551c660302c82463c7d333
error: could not apply 85c8d1604... [FIX] export: unbound formula stays unbound in snapshots
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

In the PR #3364 I try to
fix the export to excel of unbound zones by fixing them. However I have
not taken into account the normal expor in spreadsheet that is done when
generating snapshot.

This fix keeps the unbound zones in snapshots, while convert them into
bound zones in excel export.

X-original-commit: 0ed2720
@VincentSchippefilt VincentSchippefilt force-pushed the saas-16.4-16.0-fix-export-formula-vsc-Hdm2-fw branch from 67a8f32 to 1850c8e Compare February 6, 2024 13:18
@VincentSchippefilt
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 6, 2024
In the PR #3364 I try to
fix the export to excel of unbound zones by fixing them. However I have
not taken into account the normal expor in spreadsheet that is done when
generating snapshot.

This fix keeps the unbound zones in snapshots, while convert them into
bound zones in excel export.

closes #3622

X-original-commit: 0ed2720
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
@robodoo robodoo closed this Feb 6, 2024
@fw-bot fw-bot deleted the saas-16.4-16.0-fix-export-formula-vsc-Hdm2-fw branch February 20, 2024 13:46
rrahir added a commit that referenced this pull request Apr 26, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

Task: 3895465
robodoo pushed a commit that referenced this pull request Apr 27, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

closes #4146

Task: 3895465
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
fw-bot pushed a commit that referenced this pull request Apr 27, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

Task: 3895465
X-original-commit: c8df5d0
LucasLefevre pushed a commit that referenced this pull request May 3, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

Task: 3895465
X-original-commit: c8df5d0
LucasLefevre pushed a commit that referenced this pull request May 3, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

Task: 3895465
X-original-commit: c8df5d0
robodoo pushed a commit that referenced this pull request May 3, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

closes #4147

Task: 3895465
X-original-commit: c8df5d0
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
fw-bot pushed a commit that referenced this pull request May 3, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

Task: 3895465
X-original-commit: e8d1444
LucasLefevre pushed a commit that referenced this pull request May 3, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

Task: 3895465
X-original-commit: e8d1444
robodoo pushed a commit that referenced this pull request May 3, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

closes #4164

Task: 3895465
X-original-commit: e8d1444
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
fw-bot pushed a commit that referenced this pull request May 3, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

Task: 3895465
X-original-commit: 0ef57de
fw-bot pushed a commit that referenced this pull request May 3, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

Task: 3895465
X-original-commit: 0ef57de
robodoo pushed a commit that referenced this pull request May 3, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

closes #4167

Task: 3895465
X-original-commit: 0ef57de
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
robodoo pushed a commit that referenced this pull request May 3, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

closes #4166

Task: 3895465
X-original-commit: 0ef57de
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants